-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: upgrade assets controllers v33.0.0 #11755
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected] |
Bitrise✅✅✅ Commit hash: 4d45dff Note
|
@@ -99,7 +99,7 @@ describe('CollectibleContracts', () => { | |||
AccountsController: MOCK_ACCOUNTS_CONTROLLER_STATE, | |||
NftController: { | |||
allNfts: { | |||
[MOCK_ADDRESS]: { | |||
[MOCK_ADDRESS.toLowerCase()]: { | |||
'0x1': [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NftController now gets the selected address from AccountsController:getAccount
which is not a checksum address
19349a5
to
1374f76
Compare
1374f76
to
1d8d2db
Compare
Quality Gate passedIssues Measures |
Closing in favor of another |
Description
WIP
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist